Bug 46473 - Code that uses BaseScriptingEnvironment.createWindow() now won't compile
Summary: Code that uses BaseScriptingEnvironment.createWindow() now won't compile
Status: NEW
Alias: None
Product: Batik - Now in Jira
Classification: Unclassified
Component: Bridge (show other bugs)
Version: 1.8
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: Batik Developer's Mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-04 17:35 UTC by Cameron McCormack
Modified: 2009-05-31 02:36 UTC (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack 2009-01-04 17:35:20 UTC
In r665947, BaseScriptingEnvironment.createWindow() was made protected.  Some published code, such as the example at http://xmlgraphics.apache.org/batik/using/scripting/java.html, uses this method and assumes it's public.

The method should be made public once again, but rewritten so that a single Window object only ever exists (so it will act like the getWindow() method does now).  A new, different protected method that subclasses should override to provide a concrete Window object should be used.
Comment 1 Helder Magalhães 2009-05-31 02:36:42 UTC
(In reply to comment #0)
> In r665947, BaseScriptingEnvironment.createWindow() was made protected.  Some
> published code, such as the example at
> http://xmlgraphics.apache.org/batik/using/scripting/java.html, uses this method
> and assumes it's public.

Breaking documentation sample code it's always unfortunate... :-|


> The method should be made public once again, but rewritten so that a single
> Window object only ever exists (so it will act like the getWindow() method does
> now).  A new, different protected method that subclasses should override to
> provide a concrete Window object should be used.

I'm CC'ing G. Wade Johnson as I have a feeling this may also have something to do with the Window improvements tracked in issue 46072 (in revision 712954) and he might be the right person to provide a patch, even if preliminary. ;-)