Bug 46580 - NotImplementedFunction should throw an exception instead of silent internal errors
Summary: NotImplementedFunction should throw an exception instead of silent internal e...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: 3.0-FINAL
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-21 18:00 UTC by Josh Micich
Modified: 2009-01-21 18:00 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Micich 2009-01-21 18:00:12 UTC
This change was motivated by these threads:
http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3Ca644352c0901131503q44ce53a0ld9e225bbe0419642@mail.gmail.com%3E

http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3C4551EAB41622EC4AA6CFAAB005485C01D533FD@SFPWMF107.polk.com%3E

When the evaluator comes across an unimplemented function, an internal error code was returned.  This value is not suitable for writing into a FormulaRecord or BoolErrRecord, because it causes errors when opening the file in Excel.
Comment 1 Josh Micich 2009-01-21 18:00:34 UTC
The fix is to remove ErrorEval.FUNCTION_NOT_IMPLEMENTED change all methods that returned that value to throw NotImplementedException instead.

Applied in svn r736505