Bug 46581 - [PATCH] excel text extraction by cell type
Summary: [PATCH] excel text extraction by cell type
Status: RESOLVED WONTFIX
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.5-dev
Hardware: Macintosh Mac OS X 10.4
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2009-01-21 20:19 UTC by woody
Modified: 2014-07-30 16:00 UTC (History)
0 users


Attachments
BAD PATCH (4.99 KB, patch)
2009-01-21 20:19 UTC, woody 		Details | Diff
bzip2 patch for bug 46576 (5.03 KB, application/octet-stream)
2009-01-21 21:44 UTC, woody 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description woody 2009-01-21 20:19:59 UTC 
Created attachment 23154 [details]
BAD PATCH

addresses bug: 46576

affects these files:
M      src/java/org/apache/poi/hssf/usermodel/HSSFCell.java
M      src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java
M      src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
M      src/ooxml/interfaces-jdk15/org/apache/poi/ss/extractor/ExcelExtractor.java
M      src/ooxml/java/org/apache/poi/xssf/extractor/XSSFExcelExtractor.java


augment ExcelExtractor interface to support extracting cells by type.
EventBasedExcelExtractor implements ExcelExtractor interface.
ensures HSSFCell constants match those of Cell.
cleanup some stringbuffer->stringbuilder code.

bz2, standard patch format: svn diff > mydiff.txt ; bzip2 mydiff.txt
Comment 1 woody 2009-01-21 21:44:14 UTC 
Created attachment 23156 [details]
bzip2 patch for bug 46576

prev patch is no good.
Comment 2 Nick Burch 2014-07-30 16:00:28 UTC 
It isn't clear to me what the use-case is for this.

Given how long it has been since this patch was proposed, the fact that the use isn't clear, and that the patch no longer applies cleanly, I'm going to close this as Won't Fix

If someone can explain the use case, and why this logic belongs in the text extractor, please re-open the bug and comment