Bug 48398 - Lock fields should be final
Summary: Lock fields should be final
Alias: None
Product: Tomcat 6
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: default
Assignee: Tomcat Developers Mailing List
Depends on:
Reported: 2009-12-16 19:14 UTC by Sebb
Modified: 2010-01-06 02:51 UTC (History)
0 users

Patch to make lock fields final (1.07 KB, application/octet-stream)
2009-12-16 19:14 UTC, Sebb
Patch fields that should be final (929 bytes, patch)
2009-12-16 19:40 UTC, Sebb
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2009-12-16 19:14:51 UTC
Created attachment 24714 [details]
Patch to make lock fields final

A field that is used as a lock should be final. 

The following classes have mutable locks:


Comment 1 Sebb 2009-12-16 19:40:25 UTC
Created attachment 24717 [details]
Patch fields that should be final

Found more locks; fields could probably also be made private
Comment 2 Mark Thomas 2009-12-30 03:15:00 UTC
The patches already been applied to trunk. I have proposed them for 6.0.x.
Comment 3 Mark Thomas 2010-01-06 02:51:53 UTC
This has been fixed in 6.0.x and will be included in 6.0.23 onwards.