Bug 49510 - Remove dependency on classes copied from commons
Summary: Remove dependency on classes copied from commons
Status: RESOLVED FIXED
Alias: None
Product: Taglibs
Classification: Unclassified
Component: Standard Taglib (show other bugs)
Version: 1.2.0
Hardware: Macintosh All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-27 13:47 UTC by Jeremy Boynes
Modified: 2010-06-29 03:38 UTC (History)
0 users


Attachments
Patch remove dependencies on LRUMap (3.80 KB, patch)
2010-06-27 13:52 UTC, Jeremy Boynes 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Boynes 2010-06-27 13:47:22 UTC 
The "extra" package in standard-impl contains classes copied from Commons Collections, primarily LRUMap used in ElEvaluator and FormatDateSupport. Comments indicate this can be replaced with LinkedHashMap if the baseline is set to Java 1.4 and the project is now using Java5 so these could be removed.
Comment 1 Jeremy Boynes 2010-06-27 13:52:47 UTC 
Created attachment 25647 [details]
Patch remove dependencies on LRUMap

Once applied, the project will compile with the extras directory removed completely. There's other things in there that don't appear to be used.
Comment 2 Henri Yandell 2010-06-29 03:38:05 UTC 
Thanks Jeremy - patch applied:

svn ci -m "Removing dependency on copied LRUMap class from Commons Collections now that we're 1.5 dependent. Patch courtesy of Jeremy Boynes (#49510)"
Sending        impl/src/main/java/org/apache/taglibs/standard/lang/jstl/ELEvaluator.java
Sending        impl/src/main/java/org/apache/taglibs/standard/tag/common/fmt/FormatDateSupport.java
Transmitting file data ..
Committed revision 958854.