Bug 49629 - Some changes to the build system
Some changes to the build system
Status: RESOLVED FIXED
Product: Security - Now in JIRA
Classification: Unclassified
Component: Signature
Java 1.4.2
PC Linux
: P2 normal
: ---
Assigned To: XML Security Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-07-21 12:12 UTC by coheigea
Modified: 2010-08-14 14:19 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description coheigea 2010-07-21 12:12:45 UTC
This patch covers some build problems:

1) The fix for the recently introduced JDK 1.4 compilation error.
2) Skipped some tests if certain algorithms are not available...this
is to make the tests pass on JDK 1.4.
3) Changed the provider info and version number of XMLDSigRI, added a
"VersionTest" for this to make sure it gets changed.
4) Removed the versionless jars in libs, and replaced them with versioned jars
5) Changed build.xml test and test_jsr105 targets to depend on
build.jar - This is so that the xmlsec jar gets generated before tests
are run, and then copied into build/libs/endorsed
6) Replaced the sun.security.* dependencies in the KeySelectors test class.
Comment 1 coheigea 2010-07-21 13:05:07 UTC
Patch applied:

Author: coheigea
Date: Wed Jul 21 16:50:39 2010
New Revision: 966311

URL: http://svn.apache.org/viewvc?rev=966311&view=rev

I'm keeping this issue open to address a couple of issues:

1) The build fails if the junit jar is not present in libs
2) VersionTest fails using Maven and JDK 1.6
3) Try to replace how resources are loaded in the tests with a more robust solution.
Comment 2 coheigea 2010-08-14 14:19:58 UTC
Second patch applied:

Author: coheigea
Date: Sat Aug 14 18:16:48 2010
New Revision: 985553

URL: http://svn.apache.org/viewvc?rev=985553&view=rev
Log:
[Bug 49629] - Part II of a fix for some build issues.
 - All of the unit tests now pass in Eclipse, bar VersionTest (which is ok as it depends on a build system property).
 - I reduced the number of endorsed jars in build.xml
 - VersionTest now passes using maven and JDK 1.6.
 - I had to do some hacking to get this to work. The pom now contains a dependency plugin, to copy the dependencies to the endorsed dir (target). It also has a jar plugin, to create jars for the source and test code, all in phase test-compile.
 - I upgraded the Junit dependency to 4.8.1.