Bug 49955 - Building instructions incorrect.
Building instructions incorrect.
Status: RESOLVED FIXED
Product: Tomcat 7
Classification: Unclassified
Component: Documentation
trunk
All All
: P2 normal (vote)
: ---
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-09-17 18:28 UTC by Wesley
Modified: 2010-09-26 04:01 UTC (History)
0 users



Attachments
Fixes above problems and adds a section on shutdown. (3.59 KB, patch)
2010-09-17 18:28 UTC, Wesley
Details | Diff
Patch based on current svn to change to correct main class. (786 bytes, patch)
2010-09-24 22:11 UTC, Wesley
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley 2010-09-17 18:28:13 UTC
Created attachment 26047 [details]
Fixes above problems and adds a section on shutdown.

The building instructions are currently incorrect

 * The SVN repository URL for trunk is incorrect.
 * The implication in the text is that eclipse 4 is required. It isn't.
 * The step about the main class is incorrect.
 * The start launch argument is inferred
Comment 1 Tim Whittington 2010-09-23 06:18:28 UTC
Guide updated and improved for 7.0 based on your patch, with some modifications. Updated guide will hit the website soon.

Thanks for the contribution.
Comment 2 Wesley 2010-09-23 07:41:20 UTC
(In reply to comment #1)
> Guide updated and improved for 7.0 based on your patch, with some
> modifications. Updated guide will hit the website soon.
> 
> Thanks for the contribution.

I'd have created the .launch files if you wanted. Looking at the svn commit I think there is still an error though.

> +<br/>If you want to configure these yourself (or are using a different IDE)
> +then use <code>org.apache.catalina.startup.Catalina</code> as the main class,
> +<code>start</code>/<code>stop</code> as program arguments, and specify
> <code>-Dcatalina.home=...</code>
> +(with the name of your build directory) as VM arguments.

AFAIK org.apache.catalina.startup.Catalina no longer has a main method. I think this should be org.apache.catalina.startup.Bootstrap as it is in the two launch files.
Comment 3 Wesley 2010-09-24 22:11:55 UTC
Created attachment 26071 [details]
Patch based on current svn to change to correct main class.
Comment 4 Tim Whittington 2010-09-26 04:01:05 UTC
Startup class corrected - thanks for spotting that.