Bug 50462 - xalan import should not be optional in maven-bundle-plugin
Summary: xalan import should not be optional in maven-bundle-plugin
Status: RESOLVED FIXED
Alias: None
Product: Taglibs
Classification: Unclassified
Component: Standard Taglib (show other bugs)
Version: 1.2.0
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks: 50064
  Show dependency tree
 
Reported: 2010-12-12 21:45 UTC by Rex Wang
Modified: 2012-01-12 07:53 UTC (History)
0 users


Attachments
remove optional xalan import (534 bytes, patch)
2010-12-12 21:46 UTC, Rex Wang 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rex Wang 2010-12-12 21:45:16 UTC 
I know the Xalan might be removed in future due to the performance issue:
http://www.mail-archive.com/dev@tomcat.apache.org/msg43586.html

But so far, this seems still a hard dependency.

So I should not made it as optional in maven bundle plugin..

Will provide a patch.

-Rex
Comment 1 Rex Wang 2010-12-12 21:46:47 UTC 
Created attachment 26396 [details]
remove optional xalan import
Comment 2 Jeremy Boynes 2010-12-19 12:33:57 UTC 
It's marked optional in Maven as it is only needed if someone is using the XML tags.

Is there a way to mimic that with the OSGi references?
Comment 3 Rex Wang 2010-12-21 21:15:19 UTC 
(In reply to comment #2)
> It's marked optional in Maven as it is only needed if someone is using the XML
> tags.
> 
> Is there a way to mimic that with the OSGi references?

Not sure about that.

At least, IMO, that is not the correct way by using optional:=resolution in import-package to achieve the requirement.

I think the optional:=resolution directive is used to express that if osgi framework can not resolve the package, the codes in this bundle may use the implementation from itself or from jdk.

So if the codes have hard dependency to (explicitly import) a package, we should not make it as optional resolution.

-Rex
Comment 4 Jeremy Boynes 2010-12-31 18:31:40 UTC 
Removed optional declaration in r1054176
Comment 5 xiaming 2012-01-12 07:53:42 UTC 
Hi Devs,

Can you make a maven release for taglib 1.2? We want to use this in Geronimo release. thanks in advance!

Forrest