Bug 50580 - New Config element: TabularDataSet
Summary: New Config element: TabularDataSet
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2011-01-13 06:50 UTC by Daniel Brolund
Modified: 2017-01-25 20:10 UTC (History)
1 user (show)



Attachments
Patch for TabularDataSet element (13.23 KB, patch)
2011-01-13 06:50 UTC, Daniel Brolund
Details | Diff
Patch for TabularDataSet element NEW VERSION (13.24 KB, patch)
2011-01-13 07:58 UTC, Daniel Brolund
Details | Diff
Test cases (47.40 KB, application/octet-stream)
2011-01-16 07:12 UTC, Milamber
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Brolund 2011-01-13 06:50:32 UTC
Created attachment 26485 [details]
Patch for TabularDataSet element

Hi,

I made a simpler CSV (or any delimiter) config element, something I've been lacking for a while.

It is a bit like a cross between the CSV Data Set element and User Defined Variables. It is easy to use, you just put the data in a text area, then it will loop that data in the tests. In addition, you don't need to put the files on all nodes when doing distributed testing, which was a showstopper for me. 

I know you have a distributed file server in the pipe, but I think this element has its own merits.

I hope you'll like it. I'll be happy to hear from you, with any feedback.

BTW: My current assignment employer (I'm a consultant) would be happy if their name could appear somewhere. Is that possible? 

Cheers
Daniel
Comment 1 Daniel Brolund 2011-01-13 07:58:43 UTC
Created attachment 26486 [details]
Patch for TabularDataSet element NEW VERSION

I had a off-by-one error for the iteration counter that starts on 1 and not on 0.
Comment 2 Milamber 2011-01-16 07:10:33 UTC
Thanks for your submission. This config element bring a shortcut vs a CSV Data Set.
I thinks that Tabular Data Set behaviors must be similar to CSV Data Set. In particular when a bad value/parameter is in Data field, or when used a bad delimiter.
I have make a test cases script to show some behaviors differ with CSV Data Set

If Tabular Data Set can implement this behaviors like CSV, this will be better:
- Allow quoted data?
- Recycle on EOF? (or End of table)
- Stop thread on EOF? (or End of table)
- Sharing mode

A patch for user manual is important too.

Please note: when a patch has a new file (or several files), provide a zip file contains this file with directory tree.
Comment 3 Milamber 2011-01-16 07:12:19 UTC
Created attachment 26493 [details]
Test cases
Comment 4 Daniel Brolund 2011-01-19 03:29:44 UTC
If we are to support all features of CSV Data Set, we can add the Data text area to the CSV presenter, and have the options;

* Write text directly, manually (like the tabular)
* Load text from CSV once, then edit manually (a combo)
* Always use the data from the text (like the CSV today)

Maybe that would present a more cohesive element for that type of data?

Cheers
Daniel

(In reply to comment #2)
> Thanks for your submission. This config element bring a shortcut vs a CSV Data
> Set.
> I thinks that Tabular Data Set behaviors must be similar to CSV Data Set. In
> particular when a bad value/parameter is in Data field, or when used a bad
> delimiter.
> I have make a test cases script to show some behaviors differ with CSV Data Set
> 
> If Tabular Data Set can implement this behaviors like CSV, this will be better:
> - Allow quoted data?
> - Recycle on EOF? (or End of table)
> - Stop thread on EOF? (or End of table)
> - Sharing mode
> 
> A patch for user manual is important too.
> 
> Please note: when a patch has a new file (or several files), provide a zip file
> contains this file with directory tree.
Comment 5 Philippe Mouawad 2017-01-25 20:10:37 UTC
Shall we commit this ?
Some work has been done, there are unit tests.
Use case seems interesting.

+1 to commit it.
Thoughts ?

Thanks