Bug 50686 - HeaderManager logging to verbose when merging instances
Summary: HeaderManager logging to verbose when merging instances
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: HTTP (show other bugs)
Version: Nightly (Please specify date)
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
Keywords: PatchAvailable
Depends on:
Reported: 2011-01-29 09:39 UTC by Rainer Jung
Modified: 2011-01-30 09:57 UTC (History)
0 users

Fold unneeded warn logging into debug logging (1.07 KB, patch)
2011-01-29 09:39 UTC, Rainer Jung
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Jung 2011-01-29 09:39:37 UTC
Created attachment 26575 [details]
Fold unneeded warn logging into debug logging

When using the feature to merge HeaderManagers, e.g. using a general instance and then sample specific ones, there's a warn log statement issued for each sample. This fills the log quickly, makes it hard to find serious messages in the log file and doesn't actually add usueful information.

The attached patch merges the problematic warn logging into the existing debug logging. The fact that merging is being done doesn't seem to warrant a warn message, since it is a supported feature documented by the component reference page.

Thanks for the good work on JMeter!
Comment 1 Milamber 2011-01-30 04:53:07 UTC
Thanks. I think downgrade the log level is just sufficient.

URL: http://svn.apache.org/viewvc?rev=1065240&view=rev
Bug 50686 - HeaderManager logging to verbose when merging instances
Downgrade to debug

Comment 2 Rainer Jung 2011-01-30 06:04:33 UTC
Hi Milamber,

thanks for downgrading the message.

Please reconsider merging the two debug log statements:

- The missing isDebugEnabled() for the first call makes it more expensive than necessary. The whole argument formatting will be done before calling debug() for every sample, even if debug logging is not activated.

- The two debug messages are redundant and joining them into one message reduces debug log volume without removing any information from the log

Thanks again!

Comment 3 Sebb 2011-01-30 09:57:33 UTC

URL: http://svn.apache.org/viewvc?rev=1065299&view=rev
Bug 50686 - merge separate debug statements
Comment 4 The ASF infrastructure team 2022-09-24 20:37:45 UTC
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2463