Bug 52740 - An incomplete fix for the resource leak bug in Javadoc.java
Summary: An incomplete fix for the resource leak bug in Javadoc.java
Status: RESOLVED FIXED
Alias: None
Product: Ant
Classification: Unclassified
Component: Core (show other bugs)
Version: 1.8.2
Hardware: All All
: P2 minor (vote)
Target Milestone: 1.9.0
Assignee: Ant Notifications List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-23 07:06 UTC by lianggt08
Modified: 2012-02-27 21:43 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lianggt08 2012-02-23 07:06:36 UTC
The fix revision 272583 was aimed to remove resource leak bugs on the PrintWriter object "srcListWriter" (created in line 1684) in the method "execute"of the file 
"/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javadoc.java" , but it is incomplete.

There are some problems: 
1. when "srcListWriter" isn't created successfully but the temp FileWriter object is created successfully (at line 1685), the temp FileWriter object will be leaked. 

The best way to close such resource objects is putting such close operations for all resource objects in the finaly block of a try-catch-finally structure and then putting all other code in a try block.

The problem still exists in the head revision (the temp FileWriter object created at 1723 can be leaked).
Comment 1 Jesse Glick 2012-02-27 21:43:56 UTC
Committed revision 1294345.