Bug 52780 - Some memory buglets in AddOutputFilterByType in 2.4.1
Summary: Some memory buglets in AddOutputFilterByType in 2.4.1
Status: RESOLVED DUPLICATE of bug 52755
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_filter (show other bugs)
Version: 2.4.1
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2012-02-27 15:15 UTC by Maksim Orlovich
Modified: 2012-02-27 18:38 UTC (History)
0 users


Attachments
patch (1.04 KB, patch)
2012-02-27 15:15 UTC, Maksim Orlovich 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maksim Orlovich 2012-02-27 15:15:41 UTC 
Created attachment 28393 [details]
patch

Hi.. I stumbled on a couple of bugs in handling of AddOutputFilterByType in 2.4.1 when running mod_pagespeed's integration tests against it, which the attached patch should fix:

1) in filter_bytype, there is an off-by-one in writing the null termination of the  types array.

2) In add_filter, only one of the ->types or ->expr fields is written, but the structure is allocated without zeroing, so you can end up with a junk value of the other field.
Comment 1 Jeff Trawick 2012-02-27 18:38:57 UTC 

*** This bug has been marked as a duplicate of bug 52755 ***