Bug 52976 - Gratuitous string-duplication in module-configuration (apr_pstrdup)
Summary: Gratuitous string-duplication in module-configuration (apr_pstrdup)
Status: RESOLVED LATER
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_ftp (show other bugs)
Version: 2.2.22
Hardware: PC All
: P2 minor (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: MassUpdate
Depends on:
Blocks:
 
Reported: 2012-03-23 01:09 UTC by Mikhail T.
Modified: 2018-11-07 21:08 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2012-03-23 01:09:12 UTC
Every string passed to the configuration-parsing functions in mod_ftp.c is duplicated (via apr_pstrdup) for the ftp_server_config-structure, instead of simply recording a direct reference to it (as const char *).

Such duplication seems redundant. Is there anything wrong with the following replacement, for example:

-       fsc->homedir = apr_pstrdup(cmd->pool, dir);
+       fsc->homedir = dir;

Does not the configuration-parsing pool live forever?

My own little module here treats such strings the way I propose -- it never has a crash, and valgrind has no issues with it whatsoever...
Comment 1 William A. Rowe Jr. 2018-11-07 21:08:25 UTC
Please help us to refine our list of open and current defects; this is a mass update of old and inactive Bugzilla reports which reflect user error, already resolved defects, and still-existing defects in httpd.

As repeatedly announced, the Apache HTTP Server Project has discontinued all development and patch review of the 2.2.x series of releases. The final release 2.2.34 was published in July 2017, and no further evaluation of bug reports or security risks will be considered or published for 2.2.x releases. All reports older than 2.4.x have been updated to status RESOLVED/LATER; no further action is expected unless the report still applies to a current version of httpd.

If your report represented a question or confusion about how to use an httpd feature, an unexpected server behavior, problems building or installing httpd, or working with an external component (a third party module, browser etc.) we ask you to start by bringing your question to the User Support and Discussion mailing list, see [https://httpd.apache.org/lists.html#http-users] for details. Include a link to this Bugzilla report for completeness with your question.

If your report was clearly a defect in httpd or a feature request, we ask that you retest using a modern httpd release (2.4.33 or later) released in the past year. If it can be reproduced, please reopen this bug and change the Version field above to the httpd version you have reconfirmed with.

Your help in identifying defects or enhancements still applicable to the current httpd server software release is greatly appreciated.