Bug 53015 - missing apr_socket_close
Summary: missing apr_socket_close
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_proxy_connect (show other bugs)
Version: 2.5-HEAD
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Reported: 2012-03-31 20:07 UTC by Julia Lawall
Modified: 2021-01-17 16:22 UTC (History)
0 users

patch adding a call to apr_socket_close (490 bytes, patch)
2012-03-31 20:07 UTC, Julia Lawall
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julia Lawall 2012-03-31 20:07:01 UTC
Created attachment 28523 [details]
patch adding a call to apr_socket_close

In the function proxy_connect_handler, most of the error-handling code calls apr_socket_close.  This patch adds it in the case where it is missing.
Comment 1 Christophe JAILLET 2018-05-27 20:42:10 UTC
Fixed in r1832348.
Thx for the report, and sorry for the really long delay.

Maybe it's time to add some error handling gotos in apache, Linux style :)
Comment 2 Graham Leggett 2021-01-17 16:22:46 UTC
Backported to v2.4.47.