Bug 53021 - Minor bug in WebSocketServlet#headerContainsToken
Minor bug in WebSocketServlet#headerContainsToken
Product: Tomcat 7
Classification: Unclassified
Component: Catalina
PC Linux
: P2 normal (vote)
: ---
Assigned To: Tomcat Developers Mailing List
Depends on:
  Show dependency tree
Reported: 2012-04-01 14:47 UTC by mgrigorov
Modified: 2012-04-07 09:13 UTC (History)
1 user (show)

headerContainsToken fix (511 bytes, patch)
2012-04-01 20:20 UTC, Johno Crawford
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mgrigorov 2012-04-01 14:47:56 UTC
There is a minor bug in WebSocketServlet#headerContainsToken(HttpServletRequest, String, String) method. It always returns 'true'. 
The second return (at the bottom of the method body) should return 'false', i.e. there is no match.
Comment 1 Johno Crawford 2012-04-01 20:20:54 UTC
Created attachment 28525 [details]
headerContainsToken fix
Comment 2 Mark Thomas 2012-04-07 09:13:55 UTC
Fixed in trunk and 7.0.x and will be included in 7.0.28 onwards.