Created attachment 29042 [details] Suggested patch to fix this bug. On failure to execute a PROPPATCH to remove a property, the error is not returned to the caller. A comment in the code says: <code snippet> 1044: /* 1045: ** Delete the property. Ignore errors -- the property is there, or 1046: ** we are deleting it for a second time. 1047: */ 1048: /* ### but what about other errors? */ 1049: (void) (*propdb->db_hooks->remove)(propdb->db, &name); </code snippet> In subversion, property deletions are subject to authorization, and hook script execution. In the current state of things, regardless of the outcome of the PROPPATCH, the client receives a 2xx class response. I suggest the attached patch to fix this.
Applied to trunk in r1476627.
Can you verify that the patch works for you? Proposed for backport to v2.4.
Proposed for backport to v2.2.
Vetoed by jorton, citing http://tools.ietf.org/html/rfc4918#section-14.23 This patch is an RFC violation, reverted on trunk.
The RFC says "Specifying the removal of a property that does not exist is not an error." What this patch is trying to solve is the "failure to delete an existing property". Can someone please explain how this is an RFC violation?