Bug 53825 - StatCalculator#getDistribution & DistributionGraph#drawSample could be more efficient
Summary: StatCalculator#getDistribution & DistributionGraph#drawSample could be more e...
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 21:18 UTC by Sebb
Modified: 2012-09-03 21:18 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2012-09-03 21:18:18 UTC
DistributionGraph#drawSample needs the values in sorted order, so it made sense (originally) for the values to be a pair of numbers that could be sorted.

However, the code now uses the StatCalculator (via SamplingStatCalculator) which by design must use a sorted TreeMap in order to be able to calculate percentiles easily.

It would be easy for the StatCalculator to return the keys and values as some kind of ordered list or array; or indeed just use the entrySet as is, rather than creating a (larger) copy of the entrySet as an unsorted HashMap.

DistributionGraph could in fact use StatCalculator directly.

Whether this is worthwhile fixing is another matter: is the Graph actually useful?