Bug 53879 - GUI : Allow Popups to be closed with ESC key
Summary: GUI : Allow Popups to be closed with ESC key
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.7
Hardware: All All
: P2 minor (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-16 09:59 UTC by Philippe Mouawad
Modified: 2012-09-17 20:13 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2012-09-16 09:59:54 UTC 
Not all popups (JDialog) in JMeter can be closed by ESC key which brings better UI experience
Comment 1 Philippe Mouawad 2012-09-16 10:06:31 UTC 
Concerned Dialogs:
- Function Helper Dialog
- About
- Help

Use more up to date method to do so for existing ones:
- Search feature
- Row Detail
Comment 2 Philippe Mouawad 2012-09-16 10:08:08 UTC 
Date: Sun Sep 16 10:06:30 2012
New Revision: 1385239

URL: http://svn.apache.org/viewvc?rev=1385239&view=rev
Log:
Bug 53879 - GUI : Allow Popups to be closed with ESC key
Bugzilla Id: 53879

Added:
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/EscapeDialog.java   (with props)
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/config/gui/RowDetailDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/AboutCommand.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Help.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
    jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2012-09-17 20:13:19 UTC 
Date: Mon Sep 17 20:08:45 2012
New Revision: 1386800

URL: http://svn.apache.org/viewvc?rev=1386800&view=rev
Log:
Bug 53879 - GUI : Allow Popups to be closed with ESC key

Use String as less as possible
Bugzilla Id: 53879

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/config/gui/RowDetailDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/EscapeDialog.java
Comment 4 The ASF infrastructure team 2022-09-24 20:37:51 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2930