Bug 53979 - Patch to fetch Numbered List info from PPT files
Summary: Patch to fetch Numbered List info from PPT files
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: unspecified
Hardware: Macintosh All
: P2 enhancement with 4 votes (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 14:33 UTC by Alex Nikiforov
Modified: 2012-10-28 03:47 UTC (History)
0 users


Attachments
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files. (34.06 KB, patch)
2012-10-08 14:33 UTC, Alex Nikiforov 		Details | Diff
numbers.ppt that was missed in the patch (85.00 KB, application/vnd.ms-powerpoint)
2012-10-10 17:03 UTC, Alex Nikiforov 		Details
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files. Added one more test ppt with three more test cases. As well this path works well with default values. (46.22 KB, patch)
2012-10-13 19:05 UTC, Alex Nikiforov 		Details | Diff
numbers.ppt that used in the patch (85.00 KB, application/octet-stream)
2012-10-13 19:08 UTC, Alex Nikiforov 		Details
numbers2.ppt that used in the patch (867.50 KB, application/octet-stream)
2012-10-13 19:09 UTC, Alex Nikiforov 		Details
numbers.ppt that used in the patch (85.00 KB, application/octet-stream)
2012-10-15 17:10 UTC, Alex Nikiforov 		Details
numbers2.ppt that used in the patch (867.50 KB, application/octet-stream)
2012-10-15 17:11 UTC, Alex Nikiforov 		Details
numbers3.ppt that used in the patch (867.00 KB, application/octet-stream)
2012-10-15 17:11 UTC, Alex Nikiforov 		Details
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files. (63.42 KB, patch)
2012-10-15 17:13 UTC, Alex Nikiforov 		Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nikiforov 2012-10-08 14:33:55 UTC 
Created attachment 29460 [details]
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files.

Numbered list info is stored in 0x0FAC record (StyleTextProp9Atom) which belongs to 0x138b record (PP9SlideBinaryTagException) which has an older sibling CString ___PPT9 and both belong to 0x138a record (SlideProgBinaryTagContainer).
0x138a record is stored into 0x1388 record (SlideProgTagsContainer) that belongs to 0xf011 Escher Record.
  This simple architecture does not have information about to which parts of the paragraph this numbered style should be applied. This info is stored into different place and available in 0x0fa1 record (StyleTextPropAtom).
  Note: StyleTextPropAtom and StyleTextProp9Atom are two different things.
Comment 1 Yegor Kozlov 2012-10-10 10:56:47 UTC 
Alex,

numbers.ppt is missing in the patch.  Please attach it separately.

Yegor
Comment 2 Alex Nikiforov 2012-10-10 17:03:43 UTC 
Created attachment 29467 [details]
numbers.ppt that was missed in the patch

I added numbers.ppt, but realized that multishape case is not covered. When a slide has the only one text box it is working, but for two and not it is not. I will fix this and reupload the patch.
Comment 3 Alex Nikiforov 2012-10-13 19:05:51 UTC 
Created attachment 29470 [details]
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files. Added one more test ppt with three more test cases. As well this path works well with default values.

Added one more test ppt with three more test cases. As well this path works well with default values.
Comment 4 Alex Nikiforov 2012-10-13 19:08:11 UTC 
Created attachment 29471 [details]
numbers.ppt that used in the patch

numbers.ppt contains two slides with one text box each
Comment 5 Alex Nikiforov 2012-10-13 19:09:57 UTC 
Created attachment 29472 [details]
numbers2.ppt that used in the patch

numbers2.ppt contains two slides with 2 or 3 text boxes each
Comment 6 Alex Nikiforov 2012-10-15 17:10:19 UTC 
Created attachment 29478 [details]
numbers.ppt that used in the patch
Comment 7 Alex Nikiforov 2012-10-15 17:11:12 UTC 
Created attachment 29479 [details]
numbers2.ppt that used in the patch
Comment 8 Alex Nikiforov 2012-10-15 17:11:56 UTC 
Created attachment 29480 [details]
numbers3.ppt that used in the patch
Comment 9 Alex Nikiforov 2012-10-15 17:13:54 UTC 
Created attachment 29481 [details]
Code, JUnit tests and test data file with two slides to read numbered list info from ppt files.
Comment 10 Yegor Kozlov 2012-10-24 12:40:49 UTC 
Thanks for the patch, applied in r1401652

Regards,
Yegor
Comment 11 Alex Nikiforov 2012-10-28 03:47:30 UTC 
I was happy to help with fetching numbered lists from ppt files. If you have any ppt with numbered lists that does not work properly with my patch, please send these examples to anikif at gmail dot com.