Bug 54206 - ValueRecordsAggregate.updateFormulasAfterRowShift doesn't update shared formulas
Summary: ValueRecordsAggregate.updateFormulasAfterRowShift doesn't update shared formulas
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 01:03 UTC by Rui Baptista
Modified: 2012-12-04 12:45 UTC (History)
0 users


Attachments
original workbook (37.50 KB, application/vnd.ms-excel)
2012-11-26 01:58 UTC, Rui Baptista 		Details
rows shifted, v3.8-20120326 (37.50 KB, application/vnd.ms-excel)
2012-11-26 01:59 UTC, Rui Baptista 		Details
rows shifted, patched code (37.50 KB, application/vnd.ms-excel)
2012-11-26 02:01 UTC, Rui Baptista 		Details
java test code (593 bytes, application/octet-stream)
2012-11-26 02:03 UTC, Rui Baptista 		Details
tested patch (736 bytes, patch)
2012-11-26 02:11 UTC, Rui Baptista 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rui Baptista 2012-11-26 01:03:39 UTC 

    


    


      



        
          Comment 1
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 01:58:26 UTC
        

      






Created attachment 29635 [details]
original workbook

    


    


      



        
          Comment 2
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 01:59:44 UTC
        

      






Created attachment 29636 [details]
rows shifted, v3.8-20120326

    


    


      



        
          Comment 3
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 02:01:18 UTC
        

      






Created attachment 29637 [details]
rows shifted, patched code

    


    


      



        
          Comment 4
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 02:03:28 UTC
        

      






Created attachment 29638 [details]
java test code

    


    


      



        
          Comment 5
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 02:11:42 UTC
        

      






Created attachment 29639 [details]
tested patch

    


    


      



        
          Comment 6
        

        
          Rui Baptista

        

        
        

        
          2012-11-26 02:19:39 UTC
        

      






Probably the tested patch converts all shared formulas to unshared (if adjusted), the shared formula should be adjusted instead.

    


    


      



        
          Comment 7
        

        
          Yegor Kozlov

        

        
        

        
          2012-12-04 12:45:19 UTC
        

      






Thanks for the patch, applied in r1416917, junit added.

Regards,
Yegor