Bug 54254 - Check AsyncRequestWorkerFactor to make the checking style consistent
Summary: Check AsyncRequestWorkerFactor to make the checking style consistent
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mpm_event (show other bugs)
Version: 2.4.3
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: FixedInTrunk, PatchAvailable
Depends on:
Blocks:
 
Reported: 2012-12-06 07:18 UTC by Jackie Zhang
Modified: 2015-02-03 07:11 UTC (History)
1 user (show)



Attachments
a simple checker for AsyncRequestWorkerFactor (494 bytes, patch)
2012-12-06 07:18 UTC, Jackie Zhang
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jackie Zhang 2012-12-06 07:18:40 UTC
Created attachment 29712 [details]
a simple checker for AsyncRequestWorkerFactor

Hi, 

In mpm_event (server/mpm/event/event.c), there're some minor checking problem for the AsyncRequestWorkerFactor directive, which makes the configuration checking style inconsistent. 

Basically, if the input is a negative value, the code converts it to a super big unsigned integer. I suggest to add a checker like all the other module directives do. For example, LimitRequestLine, LimitRequestFieldsize, CacheMin/MaxFileSize, etc. I personally really like the idea of careful checking in Apache httpd.

The patch is really simple and tested.

Thanks,
Jackie
Comment 1 Stefan Fritsch 2012-12-25 21:52:27 UTC
Thanks, committed as r1425777 (without the explanation of AsyncRequestWorkerFactor, which I think is too simplified).
Comment 2 Christophe JAILLET 2015-02-03 07:11:28 UTC
Backported in 2.4.x in r1502204.

Is part of 2.4.5