Bug 54298 - more efficient (and shorter) method calls in FTPTaskMirrorImpl.makeRemoteDir
Summary: more efficient (and shorter) method calls in FTPTaskMirrorImpl.makeRemoteDir
Status: RESOLVED FIXED
Alias: None
Product: Ant
Classification: Unclassified
Component: Core (show other bugs)
Version: 1.9.1
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 1.9.4
Assignee: Ant Notifications List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2012-12-14 20:07 UTC by Adrian Nistor
Modified: 2014-01-02 14:39 UTC (History)
2 users (show)


Attachments
firstCall.diff (819 bytes, patch)
2012-12-14 20:07 UTC, Adrian Nistor 		Details | Diff
secondCall.diff (635 bytes, patch)
2012-12-14 20:08 UTC, Adrian Nistor 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Nistor 2012-12-14 20:07:56 UTC 
Created attachment 29757 [details]
firstCall.diff

The problem appears in version 1.8.4 and in revision 1421898.  I
attached a one-line patch (firstCall.diff) that fixes it.

In method "FTPTaskMirrorImpl.makeRemoteDir", there are two calls to
"dir.indexOf("/") == 0".  These calls should be "dir.startsWith("/")".
The intent of the call is more explicit with "startsWith" than with
"indexOf(..) == 0".  "startsWith" is also more efficient than
"indexOf", because "startsWith" tries to match only the start of the
string, while "indexOf" searches until the first occurrence.

There are many calls to "String.startsWith" in Ant (just like in the
proposed patch), for example, in methods "AntlibDefinition.setURI",
"AntClassLoader.isParentFirst", "ComponentHelper.checkNamespace",
"Execute.getVMSLogicals", "ExecTask.isPath", "Jar.writeIndexLikeList",
"Definer.makeResourceFromURI", "PathTokenizer.nextToken", etc.

I attached a second one-line patch (secondCall.diff) for the second
call.
Comment 1 Adrian Nistor 2012-12-14 20:08:12 UTC 
Created attachment 29758 [details]
secondCall.diff
Comment 2 Stefan Bodewig 2014-01-02 14:39:12 UTC 
svn revision 1554813