Bug 54302 - more efficient (and shorter) method call in FTPTaskMirrorImpl.FTPDirectoryScanner.AntFTPFile.getFastRelativePath
Summary: more efficient (and shorter) method call in FTPTaskMirrorImpl.FTPDirectorySca...
Status: RESOLVED FIXED
Alias: None
Product: Ant
Classification: Unclassified
Component: Core (show other bugs)
Version: 1.9.1
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 1.9.4
Assignee: Ant Notifications List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2012-12-14 21:10 UTC by Adrian Nistor
Modified: 2014-01-02 14:40 UTC (History)
2 users (show)


Attachments
patch (797 bytes, patch)
2012-12-14 21:10 UTC, Adrian Nistor 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Nistor 2012-12-14 21:10:45 UTC 
Created attachment 29763 [details]
patch

The problem appears in version 1.8.4 and in revision 1421898.  I
attached a one-line patch that fixes it.

In method "FTPTaskMirrorImpl.FTPDirectoryScanner.AntFTPFile.getFastRelativePath",
the call "absPath.indexOf(rootPath + task.getSeparator()) == 0" should
be "absPath.startsWith(rootPath + task.getSeparator())".  The intent
of the call is more explicit with "startsWith" than with "indexOf(..)==0".
"startsWith" is also more efficient than "indexOf", because
"startsWith" tries to match only the start of the string, while
"indexOf" searches until the first occurrence.

There are many calls to "String.startsWith" in Ant (just like in the
proposed patch), for example, in methods "AntlibDefinition.setURI",
"AntClassLoader.isParentFirst", "ComponentHelper.checkNamespace",
"Execute.getVMSLogicals", "ExecTask.isPath", "Jar.writeIndexLikeList",
"Definer.makeResourceFromURI", "PathTokenizer.nextToken", etc.
Comment 1 Stefan Bodewig 2014-01-02 14:40:11 UTC 
svn revision 1554813