Bug 54944 - Enhancements to TestFormAuthenticator
Summary: Enhancements to TestFormAuthenticator
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.0.x-trunk
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
Depends on:
Reported: 2013-05-09 14:33 UTC by Brian Burch
Modified: 2013-05-28 11:09 UTC (History)
0 users

svn diff: update to test class (27.64 KB, patch)
2013-05-09 14:33 UTC, Brian Burch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burch 2013-05-09 14:33:23 UTC
Created attachment 30266 [details]
svn diff: update to test class

I have attached an extensive patch to this existing test class. The main benefit is better comments and self-documenting arguments to the common worker methods, which should be helpful to anyone investigating tomcat authentication behaviour but who does not have a detailed understanding of its internal logic.

The motive and techniques used here bring the source into line with an earlier enhancement to the TestNonLoginAndBasicAuthenticator, i.e. https://issues.apache.org/bugzilla/show_bug.cgi?id=54190#c4

All tests should pass with the latest trunk. Code style should be acceptable.
Comment 1 Mark Thomas 2013-05-28 11:09:21 UTC
Thanks for the patch. Applied (with one minor change) to trunk and 7.0.x and will be included in 7.0.41 onwards.