Created attachment 30351 [details] new function delta + testcases new function delta + testcases
Patch applied in r1488730 but there is some work to do . DELTA is a function from the Excel Analysis Toolpack . It needs to implement FreeRefFunction and be registered in org.apache.poi.ss.formula.atp.AnalysisToolPak. Otherwise the formula evaluator will not find it. What you need to do: (1) Declare DELTA as implementing FreeRefFunction . There is one method to implement and you need to simply delegate it to the existing implementation: public ValueEval evaluate(ValueEval[] args, OperationEvaluationContext ec) { if (args.length != 2) { return ErrorEval.VALUE_INVALID; } return evaluate(ec.getRowIndex(), ec.getColumnIndex(), args[0], args[1]); } (2) register DELTA in AnalysisToolPack, see how other functions are registered and follow the pattern. (3) Provide a test(s) that evaluate functions from a real excel file. Attach the modified test workbook to this bug report. Yegor
Created attachment 30365 [details] This spreadsheet contains various test cases for the functions: DELTA
Created attachment 30366 [details] This spreadsheet contains various test cases for the functions: DELTA
You seem to attached the test spreadsheet instead of the patch. Please re-attach. Yegor
Created attachment 30380 [details] patch : TestDeltaFunctionsFromSpreadsheet.java Delta.java AnalysisToolPak.java
Add missing TestDeltaFunctionsFromSpreadsheet and register Delta in AnalysisToolPak in r1529809