Bug 55041 - [PATCH] patch for missing function CODE
[PATCH] patch for missing function CODE
Status: RESOLVED FIXED
Product: POI
Classification: Unclassified
Component: POI Overall
3.10-dev
PC All
: P2 normal (vote)
: ---
Assigned To: POI Developers List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-06-01 09:57 UTC by Cédric Walter
Modified: 2013-06-02 23:33 UTC (History)
0 users



Attachments
patch for missing function CODE + testcases (1.91 KB, application/gzip)
2013-06-01 09:57 UTC, Cédric Walter
Details
Tests CODE() as loaded from a test data spreadsheet. (27.00 KB, application/vnd.ms-excel)
2013-06-02 20:51 UTC, Cédric Walter
Details
CODE_2.patch + test loader from spreadsheet + FunctionEval Required changes (2.43 KB, patch)
2013-06-02 20:52 UTC, Cédric Walter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Walter 2013-06-01 09:57:01 UTC
Created attachment 30356 [details]
patch for missing function CODE + testcases

patch for missing function CODE + testcases
Comment 1 Yegor Kozlov 2013-06-02 16:00:02 UTC
Applied in r1488733. This patch needs to address same fixes as Bugs 55037 and 55036. 

Yegor
Comment 2 Cédric Walter 2013-06-02 17:50:07 UTC
CODE is not a function of the Analysis Toolpack Function Definitions.
there is no entry in the map of org.apache.poi.ss.formula.atp.AnalysisToolPak#createFunctionsMap

Are you sure it need also to be added to Analysis Toolpack Function?

Cédric
Comment 3 Cédric Walter 2013-06-02 20:51:37 UTC
Created attachment 30371 [details]
Tests CODE() as loaded from a test data spreadsheet.
Comment 4 Cédric Walter 2013-06-02 20:52:24 UTC
Created attachment 30372 [details]
CODE_2.patch + test loader from spreadsheet + FunctionEval Required changes
Comment 5 Yegor Kozlov 2013-06-02 23:33:57 UTC
Thanks for the quick update. Applied in r1488810

You are right, CODE does not belong to the Analysis Toolpack. It needs to be registered in FunctionEval 


Yegor