Bug 55118 - Change Javadoc generation per CVE-2013-1571, VU#225657
Summary: Change Javadoc generation per CVE-2013-1571, VU#225657
Status: NEW
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: Site & Docs (show other bugs)
Version: 1.2.19
Hardware: All All
: P2 critical
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-18 23:38 UTC by Nick Williams
Modified: 2013-06-24 21:08 UTC (History)
2 users (show)



Attachments
JavaDoc patch (generated with JavaDocFixTool) (4.38 KB, patch)
2013-06-21 19:20 UTC, Olivier Jaquemet
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Williams 2013-06-18 23:38:13 UTC
Oracle has announced a Javadoc vulnerability (CVE-2013-1571 [1], VU#225657 [2]) whereby Javadoc generated with Java 5, Java 6, or Java 7 < 7u25 is vulnerable to a frame injection attack. Oracle has provided a repair-in-place tool for Javadoc that cannot be easily interpreted, but is urging developers to regenerate whatever Javadoc they can using Java 7u25. For all practical purses, the vulnerability really only applies to publicly-hosted Javadoc, so the Javadoc in our existing Maven artifacts really doesn't have to be worried about (not that we could do anything about it). My thoughts on this:

1) We should apply the repair-in-place tool ASAP to the Javadoc on the website for Log4j 1 and Log4j 2.

2) Future Log4j 1 and 2 Javadoc should be generated with 7u25 or better. There will be no fix for Java 5 or 6. Thankfully, generating Javadoc using a different JDK than you used to compile is quite easy in both Maven and Ant. In fact, I prefer it that way, because the Javadoc is much more visually attractive in Java 7.

[1] http://www.oracle.com/technetwork/topics/security/javacpujun2013-1899847.html
[2] http://www.kb.cert.org/vuls/id/225657
Comment 1 Nick Williams 2013-06-18 23:44:18 UTC
- that cannot be easily interpreted
+ that cannot be easily regenerated

Not even sure how that happened...
Comment 2 Olivier Jaquemet 2013-06-21 19:20:49 UTC
Created attachment 30469 [details]
JavaDoc patch (generated with JavaDocFixTool)

Patch generated using official JavaDocFixTool provided by Oracle, against site repository : 

https://svn.apache.org/repos/asf/logging/site/trunk/docs/log4j/1.2

I don't know how to change the build process to ensure the javadoc is generated with the latest version of the JDK.
Comment 3 Ralph Goers 2013-06-24 21:08:47 UTC
I have patched the live web site. The Log4j 1.x build still needs to be updated to  permanently resolve this.