Bug 55455 - HTTPS with HTTPClient4 ignores cps setting
Summary: HTTPS with HTTPClient4 ignores cps setting
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 2.9
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
: 55456 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-20 18:09 UTC by apache
Modified: 2014-04-28 06:40 UTC (History)
3 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description apache 2013-08-20 18:09:20 UTC 
setting

httpclient.socket.http.cps=50
httpclient.socket.https.cps=50

jmx with 
<HTTPSamplerProxy ...
<stringProp name="HTTPSampler.implementation">HttpClient4</stringProp>
</HTTPSamplerProxy>

when using https urls the cps setting is ignored


likely cause is an unused parameter in 
src/protocol/http/org/apache/jmeter/protocol/http/util/HC4TrustAllSSLSocketFactory.java (not verified) 

---snip--
  protected HC4TrustAllSSLSocketFactory(javax.net.ssl.SSLSocketFactory factory) throws GeneralSecurityException {
        super(TRUSTALL, SSLSocketFactory.ALLOW_ALL_HOSTNAME_VERIFIER);
        this.factory = new HttpSSLProtocolSocketFactory((JsseSSLManager)JsseSSLManager.getInstance());
    }
---snip--

the factory parameter is ignored and a default socket factory newly created without the cps setting
Comment 1 simon@ 2013-08-20 18:14:16 UTC 
*** Bug 55456 has been marked as a duplicate of this bug. ***
Comment 2 Philippe Mouawad 2013-08-20 19:53:08 UTC 
Date: Tue Aug 20 19:51:55 2013
New Revision: 1515950

URL: http://svn.apache.org/r1515950
Log:
Bug 55455 - HTTPS with HTTPClient4 ignores cps setting
Bugzilla Id: 55455

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HC4TrustAllSSLSocketFactory.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml
Comment 3 Philippe Mouawad 2013-08-20 19:56:50 UTC 
Note the Java Sampler now also supports the speed limitation.

Your feedback on this is welcome.
Comment 4 Philippe Mouawad 2013-08-20 20:02:26 UTC 
Date: Tue Aug 20 20:01:43 2013
New Revision: 1515953

URL: http://svn.apache.org/r1515953
Log:
Bug 55455 - HTTPS with HTTPClient4 ignores cps setting
Remove deprecated note
Bugzilla Id: 55455

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
Comment 5 The ASF infrastructure team 2022-09-24 20:37:54 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3201