Bug 55512 - Summariser should be enabled by default in Non GUI mode
Summary: Summariser should be enabled by default in Non GUI mode
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.9
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 20:35 UTC by Philippe Mouawad
Modified: 2016-01-06 21:07 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2013-08-31 20:35:09 UTC 
I think this very useful option should be enabled by default to encourage usage of non gui mode and because it has very low impact on performances.
Comment 1 Sebb 2013-09-01 19:30:25 UTC 
I think this should be discussed on the DEV list first please.
Keep this issue open until the discussion is resolved.
Comment 2 Philippe Mouawad 2013-09-22 19:37:04 UTC 
I propose changing the following:
- summariser.interval => 30 s
in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) , change JMeterUtils.getPropDefault("summariser.name", "") to JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser")

I no objection, I will be commiting this tomorrow evening.
Comment 3 Sebb 2013-09-22 22:54:39 UTC 
(In reply to Philippe Mouawad from comment #2)
> I propose changing the following:
> - summariser.interval => 30 s

Why?

> in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) ,
> change JMeterUtils.getPropDefault("summariser.name", "") to
> JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser")

Not a good idea to have such a long name as it can cause unnecessary wrapping.
That's why the default is empty.
Comment 4 Philippe Mouawad 2013-09-27 23:19:42 UTC 
(In reply to Sebb from comment #3)
> (In reply to Philippe Mouawad from comment #2)
> > I propose changing the following:
> > - summariser.interval => 30 s
> 
> Why?
> 
Because 180s seems to me a long interval to react to test event

> > in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) ,
> > change JMeterUtils.getPropDefault("summariser.name", "") to
> > JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser")
> 
> Not a good idea to have such a long name as it can cause unnecessary
> wrapping.
> That's why the default is empty.
But if we keep it empty it will not be enabled, or do I misunderstand something ?
Comment 5 Philippe Mouawad 2013-11-23 14:35:46 UTC 
Any feedback on this ?
Comment 6 Sebb 2013-11-23 15:56:48 UTC 
(In reply to Philippe Mouawad from comment #4)
> (In reply to Sebb from comment #3)
> > (In reply to Philippe Mouawad from comment #2)
> > > I propose changing the following:
> > > - summariser.interval => 30 s
> > 
> > Why?
> > 
> Because 180s seems to me a long interval to react to test event
> 
> > > in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) ,
> > > change JMeterUtils.getPropDefault("summariser.name", "") to
> > > JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser")
> > 
> > Not a good idea to have such a long name as it can cause unnecessary
> > wrapping.
> > That's why the default is empty.

Ignore that.

> But if we keep it empty it will not be enabled, or do I misunderstand
> something ?

No, you are correct, but using a long name causes unnecessary word-wrap
Comment 7 Philippe Mouawad 2013-12-12 21:29:27 UTC 
Date: Thu Dec 12 21:28:40 2013
New Revision: 1550536

URL: http://svn.apache.org/r1550536
Log:
Bug 55512 - Summariser should be enabled by default in Non GUI mode
Bugzilla Id: 55512

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
    jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
    jmeter/trunk/xdocs/changes.xml
Comment 8 Sebb 2015-08-29 22:07:55 UTC 
The jmeter.properties file still says:

# Define the following property to automatically start a summariser with that name
# (applies to non-GUI mode only)
#summariser.name=summary

This implies that the summariser won't be started unless the property is defined, however that is no longer the case, because the code defaults to summariser.name=summary.

We can either:
1) fix the properties file, or 
2) revert the code change and enable the property in the property file.

It's now a bit awkward to disable the summariser, one has to put the following in the file:

summariser.name=

Luckily leading spaces and tabs are ignored when the properties file is parsed, so invisble spaces won't start the summariser, but it still looks wrong to me.

Therefore I favour option 2.
Any objections?
Comment 9 Philippe Mouawad 2015-12-27 21:14:56 UTC 
No objections for me.
Comment 10 Sebb 2016-01-06 00:35:05 UTC 
URL: http://svn.apache.org/viewvc?rev=1723203&view=rev
Log:
 Summariser should be enabled by default in Non GUI mode
 Revert the changes made in r1550536 and just enable via jmeter.properties
Bugzilla Id: 55512

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
    jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
Comment 11 Philippe Mouawad 2016-01-06 21:07:35 UTC 
Author: pmouawad
Date: Wed Jan  6 21:03:36 2016
New Revision: 1723411

URL: http://svn.apache.org/viewvc?rev=1723411&view=rev
Log:
[Bug 55512] Summariser should be enabled by default in Non GUI mode
Restore 30 seconds as interval
Bugzilla Id: 55512

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
Comment 12 The ASF infrastructure team 2022-09-24 20:37:55 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3221