Bug 55873 - [PATCH] implementing new formula COUNTIFS
Summary: [PATCH] implementing new formula COUNTIFS
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.10-dev
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2013-12-12 17:03 UTC by Detlef Brendle
Modified: 2014-01-23 16:44 UTC (History)
0 users

patch (1.55 KB, application/gzip)
2013-12-12 17:03 UTC, Detlef Brendle
new Countifs function patch (1.65 KB, application/gzip)
2014-01-22 15:26 UTC, Detlef Brendle

Note You need to log in before you can comment on or make changes to this bug.
Description Detlef Brendle 2013-12-12 17:03:40 UTC
Created attachment 31110 [details]

Implemeting formula COUNTIFS including test case
Comment 1 Nick Burch 2014-01-22 11:34:57 UTC
Generally looks good, but a couple of minor points:
 * Unit tests should normally use assertEquals rather than naked asserts, so that the test runner can better capture problems
 * I can't see anything that registers the function, is something needed?
Comment 2 Detlef Brendle 2014-01-22 15:14:26 UTC
Hi Nick,
the registration I will have a look. Thought there might be a automatic registration mechanism, but will check it.
The Unit Test uses assert, because I come from the Groovy side and there it doenst matter. Will fix that too.
Comment 3 Detlef Brendle 2014-01-22 15:26:23 UTC
Created attachment 31248 [details]
new Countifs function patch

- register COUNTIFS in AnalysisToolpack
- adjust testcase
Comment 4 Detlef Brendle 2014-01-22 15:26:39 UTC
Comment 5 Nick Burch 2014-01-23 16:44:59 UTC
Thanks, patch applied in r1560736.