Bug 56159 - Spurious notification that the test plan has changed
Summary: Spurious notification that the test plan has changed
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.11
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-19 13:22 UTC by Sebb
Modified: 2014-09-13 13:45 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2014-02-19 13:22:55 UTC 
It looks as though the addition of the jmeter version attribute to the jmeterTestPlan tag in the JMX file has the unfortunate side effect of marking the plan "dirty" and asking whether to save it on exit.

Ideally we need to suppress the warning if the only change is the jmeter version.
In fact the other attributes on the jmeterTestPlan should probably not cause the plan to be marked dirty either.
Comment 1 Philippe Mouawad 2014-09-13 12:55:47 UTC 
In my opinion this is not a problem, as I consider "Test Plan" is dirty since it has been migrated to new version of JMeter.

What's your opinion ?
Comment 2 Sebb 2014-09-13 13:31:03 UTC 
It seems wrong to flag the plan as dirty if the user has not changed it and the plan will operate identically.

Using an older plan should not trigger the question:
"Why has the plan changed?"

Now there are other instances where the test plan really does need to be changed (e.g. an obsolete test element is replaced).
In such cases it is useful to report a change in the plan in case it affects the user.

If every old plan triggers a dirty message, eventually the message will just be ignored. And it will annoy users.
Comment 3 Philippe Mouawad 2014-09-13 13:45:56 UTC 
Agreed, thanks for clarification