Bug 56228 - View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering
Summary: View Results Tree : Improve ergonomy by changing placement of Renderers and a...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.11
Hardware: Other All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 22:35 UTC by Philippe Mouawad
Modified: 2014-03-10 22:37 UTC (History)
1 user (show)



Attachments
Proposal (136.17 KB, image/png)
2014-03-06 22:41 UTC, Philippe Mouawad
Details
Patch proposal (4.54 KB, patch)
2014-03-06 22:57 UTC, Philippe Mouawad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2014-03-06 22:35:44 UTC
As per mailing list discussion:
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201403.mbox/%3CCAH9fUpbhfkSo6d4M6v7Xn2KJnwqq-2Gh0v_num63Rt3TrUnJkQ%40mail.gmail.com%3E

Discussion excerpt:
Philippe M. proposal
    *View Results Tree:*
    - I feel  the select box at the bottom left of component allowing selection
    of a Viewer is misplaced. I often switch between Viewers during scripting
    and I think it should a Tabbed Pane on the Top Center Right Part of View
    Results Tree or something better if you have ideas.  This would make it
    more visible and allow easy switching. Currently you lose a lot of time
    switching and finding the right component
    I also think we should at least change their display priority, I tend to
    think it should be something like
    - Text
    - Regexp Tester
    - CSS / JQUERY Test
    - XPATH Tester
    - HTML
    - HTML (download) => Very annoying that it blocks screen to download
    resource
    - Document
    - JSON => Not very useful currently
    - XML  => Do you use it ?

Milamber note:
Yes it's a good idea to change order. Except perhaps Text plain view, the order for others renderers can be different in function of situation.
Perhaps, introduce a property for ordering the renderers?
Comment 1 Philippe Mouawad 2014-03-06 22:41:25 UTC
Created attachment 31373 [details]
Proposal

New property introduced which controls order:
view.results.tree.renderers_order=org.apache.jmeter.visualizers.RenderAsText,org.apache.jmeter.visualizers.RenderAsRegexp,org.apache.jmeter.visualizers.RenderAsCssJQuery,org.apache.jmeter.visualizers.RenderAsXPath,org.apache.jmeter.visualizers.RenderAsHTML,org.apache.jmeter.visualizers.RenderAsHTMLWithEmbedded,org.apache.jmeter.visualizers.RenderAsDocument,org.apache.jmeter.visualizers.RenderAsJSON,org.apache.jmeter.visualizers.RenderAsXML,com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.RenderAsJsonRenderer,com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.RenderAsJsonRenderer

Note renderers not mentionned in list will be added after those mentionned to handle correctly plugins or errors.
Comment 2 Philippe Mouawad 2014-03-06 22:57:55 UTC
Created attachment 31374 [details]
Patch proposal
Comment 3 Sebb 2014-03-07 02:01:35 UTC
(In reply to Philippe Mouawad from comment #1)
...

> com.ubikingenierie.loadpack.json.render.RenderJsonAsXML,com.
> ubikingenierie.loadpack.json.render.RenderAsJsonRenderer,com.ubikingenierie.
> loadpack.json.render.RenderJsonAsXML,com.ubikingenierie.loadpack.json.render.
> RenderAsJsonRenderer

Why are these classes not in the JMeter package structure?
Comment 4 Philippe Mouawad 2014-03-07 14:45:53 UTC
These are plugins, forget about them, they will not be included.

Otherwise shall I commit this ?
Comment 5 Sebb 2014-03-07 15:15:58 UTC
The list is quite awkward to read.

I suggest allowing a shorthand - instead of 

org.apache.jmeter.visualizers.RenderAsText

one could use

.RenderAsText

i.e. if the class name starts with "." (which is not valid) then prepend

org.apache.jmeter.visualizers
Comment 6 Philippe Mouawad 2014-03-07 17:27:54 UTC
Ok, I will implement and commit.
Comment 7 Philippe Mouawad 2014-03-10 22:37:13 UTC
Date: Mon Mar 10 22:34:31 2014
New Revision: 1576110

URL: http://svn.apache.org/r1576110
Log:
Bug 56228 - View Results Tree : Improve ergonomy by changing placement of Renderers and allowing custom ordering
Bugzilla Id: 56228

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
    jmeter/trunk/xdocs/changes.xml