Bug 56423 - Implement "fipsModeGet" method stub in case TCN is compiled without OpenSSL
Summary: Implement "fipsModeGet" method stub in case TCN is compiled without OpenSSL
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Native
Classification: Unclassified
Component: Library (show other bugs)
Version: 1.1.30
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 12:06 UTC by Konstantin Kolinko
Modified: 2014-07-02 07:40 UTC (History)
0 users


Attachments
2014-04-17_tcn_56423_fipsModeStub.patch (788 bytes, patch)
2014-04-17 12:10 UTC, Konstantin Kolinko 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kolinko 2014-04-17 12:06:15 UTC 
In native/src/ssl.c there is #else part, where each of java methods is implemented as a stub. That is for the case when the library is compiled without OpenSSL.

There is no stub for the new "fipsModeGet" method.
Comment 1 Konstantin Kolinko 2014-04-17 12:10:59 UTC 
Created attachment 31537 [details]
2014-04-17_tcn_56423_fipsModeStub.patch

A patch that
a) implements fipsModeGet
b) changes fipsModeSet to throw an exception

(There exist other stub methods that throw exceptions: see TCN_IMPLEMENT_CALL(jint, SSL, initialize))

The patch is untested.
Comment 2 Konstantin Kolinko 2014-07-02 07:40:00 UTC 
The patch was applied to native trunk and 1.1.x (r1607264).
It will be in 1.1.31 onwards.