Bug 56424 - Comments constructor doesn't set row and column of the VML shape
Summary: Comments constructor doesn't set row and column of the VML shape
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SXSSF (show other bugs)
Version: 3.10-FINAL
Hardware: PC All
: P2 regression (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks: 58175
  Show dependency tree
 
Reported: 2014-04-17 14:23 UTC by Vincent Boulanger
Modified: 2015-07-24 12:05 UTC (History)
1 user (show)



Attachments
An example of problematic file creation. (3.23 KB, text/x-java-source)
2014-04-17 14:23 UTC, Vincent Boulanger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Boulanger 2014-04-17 14:23:06 UTC
Created attachment 31539 [details]
An example of problematic file creation.

In version 3.9 of SXSSF, when creating comments with createCellComment(ClientAnchor), the first point of the anchor was used to set the properties <x:Row> and <x:Column> of the VML shape. 
In version 3.10, if you don't explicitely call setColumn and setRow, theses properties are left to zero and excel (v14.0.7116.5000) throw an error when opening the spreadsheet.
Maybe it's an expected new behavior but in that case, the function createCellComment(ClientAnchor) should be changed to reflect this behavior.
Comment 1 Dominik Stadler 2015-07-24 12:05:58 UTC
This is now fixed again via r1692483, it was a regression that was introduced in 2013 as part of fixing Bug 54920.