Bug 56469 - [PATCH] patch for XWPF to support adding comments
Summary: [PATCH] patch for XWPF to support adding comments
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: XWPF (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2014-04-29 01:34 UTC by Brady Alleman
Modified: 2019-08-20 09:37 UTC (History)
2 users (show)



Attachments
a .tar.gz generated using "ant -f patch.xml" for supporting adding comments (6.20 KB, application/x-gzip)
2014-04-29 01:34 UTC, Brady Alleman
Details
a .tar.gz generated using "ant -f patch.xml" for supporting adding and editing comments (19.63 KB, patch)
2016-02-19 13:54 UTC, Simon Sperl
Details | Diff
33570: a .tar.gz generated using "ant -f patch.xml" for supporting adding and editing comments (19.59 KB, patch)
2016-02-19 14:39 UTC, Simon Sperl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Alleman 2014-04-29 01:34:50 UTC
Created attachment 31568 [details]
a .tar.gz generated using "ant -f patch.xml" for supporting adding comments

The attached is a .tar.gz generated using "ant -f patch.xml".  The goal of the patch is to allow adding and saving of new comments, while the existing support was mostly useful for reading them.  I will gladly accept feedback on how to better structure the changes.  Includes test case.
Comment 1 Nick Burch 2014-04-29 09:22:23 UTC
Thanks for this

At first glance, the way of adding comments to a paragraph doesn't look quite right to me. From the unit test, it doesn't look too bad for adding a comment to a paragraph you're creating, but it doesn't look very good for the edit case. Not certain what it should be, sorry, but the current way doesn't quite feel right...

Something a bit like the unit test which is an example might be good too!
Comment 2 Simon Sperl 2016-02-19 13:54:41 UTC
Created attachment 33570 [details]
a .tar.gz generated using "ant -f patch.xml" for supporting adding and editing comments

based on a mixture of the previous patch, logic from footnote and sweat.

In general a bit confused when to use create/add/get I tried to be consistent but I am afraid there is not much precedent.

I also think there is a real need for an AbstractBody class, the code duplication is getting pretty strong.
Comment 3 Simon Sperl 2016-02-19 14:39:34 UTC
Created attachment 33571 [details]
33570: a .tar.gz generated using "ant -f patch.xml" for supporting adding and editing comments

fixes a bug in the previous patch when having perfectly overlapping commentRanges
Comment 4 Jessica Goldner 2019-07-08 12:19:48 UTC
If yo be honest I don't understand this post. I prefer to read something easier for understanding. For example, I like https://papers-writings.net/custom-term-paper-writing/. It's usually concise and easy to understand. You can come across this link and look for useful tips about writing.
Comment 5 adongoc 2019-08-05 06:46:31 UTC
Thanks for the helpful information you shared with us.
http://strikeforcekitty2.net/
Comment 6 Matt Sherwood 2019-08-19 11:20:07 UTC
The process of writing a professional APA interview paper is rather troublesome and time-consuming, especially for the individual, who do not possess excellent writing skills or do not have relevant experience. So, if you need to find out more about how to write the [url=https://primeessay.org/apa-interview-paper.html]interview apa paper[/url] , visit our website for additional consultation.
Comment 7 Sam Carter 2019-08-20 09:37:23 UTC
If you are facing a tight deadline or a written work which is of no interest to you, you have come to the right place. If you are unsure of your writing skills and need a professional to conduct the research and generate a superior piece of writing for you, you have come to the right place https://essaysleader.com