Bug 56888 - [PATCH] XSSFDataValidation ignores "allow blank" read from sheet, assumes true
Summary: [PATCH] XSSFDataValidation ignores "allow blank" read from sheet, assumes true
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2014-08-26 12:10 UTC by Chris Boyle
Modified: 2014-12-22 10:03 UTC (History)
0 users


Attachments
Patch to not overwrite allow blank value (4.63 KB, patch)
2014-08-26 12:10 UTC, Chris Boyle 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Boyle 2014-08-26 12:10:36 UTC 
Created attachment 31943 [details]
Patch to not overwrite allow blank value

XSSFDataValidation.XSSFDataValidation(CellRangeAddressList, CTDataValidation) calls ctDdataValidation.setAllowBlank(true), overwriting the original value read from the sheet. That value is therefore unavailable.

Attached is a patch from a colleague, with tests, to call setAllowBlank(true) in the DataValidationHelper instead, so it still defaults to true for write, but allows reading the actual value from the sheet.
Comment 1 Dominik Stadler 2014-12-22 10:03:55 UTC 
Thanks for the Patch, this is applied via r1647276 now.