Bug 56920 - LogViewer : Make it receive all log events even when it is closed
Summary: LogViewer : Make it receive all log events even when it is closed
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.11
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-06 13:53 UTC by UbikLoadPack support
Modified: 2014-09-07 19:52 UTC (History)
1 user (show)



Attachments
Patch (2.43 KB, patch)
2014-09-06 13:53 UTC, UbikLoadPack support
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description UbikLoadPack support 2014-09-06 13:53:43 UTC
Created attachment 31969 [details]
Patch

Hello,
LogViewer is a nice feature to see easily logs without opening jmeter.log.
Unfortunately, as it is disabled by default, it does not receive log events.
It only does when opened, which requires user to enable it then replay what lead to this error. 

This feature enables LogViewer to receive events even if closed.
It can be controlled by property:
jmeter.loggerpanel.enable_when_closed

But we propose to enable it by default (so changes.xml section needs to mention it) and user can disable it by setting property to false.

The patch we propose also adds a Hand cusor on the Warning Icon to show user it is a clickable element.

As usual, as we signed a CCLA, all rights of this code belong to Apache.

Regards
Ubik Load Pack team
Comment 1 Sebb 2014-09-06 14:18:23 UTC
One reason why it is not enabled by default is that it takes up additional memory. This can be quite considerable if debug is enabled.
Comment 2 UbikLoadPack support 2014-09-06 14:27:08 UTC
Hello,
Yes but there is a built-in protection with property:
jmeter.loggerpanel.maxlength


Being big users of JMeter as long as our customers, we feel it would be great to have this enabled.
It's like in Eclipse, Console receives events even if closed.
Comment 3 Philippe Mouawad 2014-09-07 19:51:57 UTC
Date: Sun Sep  7 19:50:07 2014
New Revision: 1623149

URL: http://svn.apache.org/r1623149
Log:
Bug 56920 - LogViewer : Make it receive all log events even when it is closed
Bugzilla Id: 56920

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/gui/LoggerPanel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/MainFrame.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/hints_and_tips.xml
Comment 4 Philippe Mouawad 2014-09-07 19:52:12 UTC
Thanks for contribution.