Bug 56951 - Add apr_queue_pop_timeout()
Summary: Add apr_queue_pop_timeout()
Status: NEW
Alias: None
Product: APR
Classification: Unclassified
Component: APR (show other bugs)
Version: HEAD
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Apache Portable Runtime bugs mailinglist
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2014-09-10 18:53 UTC by Travis Cross
Modified: 2015-03-16 17:35 UTC (History)
3 users (show)



Attachments
Add apr_queue_pop_timeout() (4.44 KB, patch)
2014-09-10 18:53 UTC, Travis Cross
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Travis Cross 2014-09-10 18:53:58 UTC
Created attachment 31992 [details]
Add apr_queue_pop_timeout()

Greetings,

The attached patch, which applies cleanly to APR HEAD, addresses an issue we experienced in using APR with the FreeSWITCH project.  We've been running this patch in FreeSWITCH's version of APR for years and would like to see it included upstream if possible.  Please let us know your thoughts and if any changes are appropriate we'll be happy to make them and propose a revised patch.

The patch series being proposed here is also available on the master branch of this repository:

  https://github.com/traviscross/apr/

Author: Anthony Minessale <anthm@freeswitch.org>
Date:   Fri Mar 14 01:35:26 2014 +0500

    Add apr_queue_pop_timeout()
    
    This function will pop or get an object from the queue, blocking if
    the queue is already empty for up to N microseconds.
    
    Signed-off-by: Anthony Minessale <anthm@freeswitch.org>
    Signed-off-by: Travis Cross <tc@traviscross.com>
Comment 1 Yann Ylavic 2015-03-16 17:35:47 UTC
Thanks, committed in r1667073 (+ r1667075 for credits), including both apr_queue_timedpop() and apr_queue_timedpush() (names maybe more consistent with other APR timed functions), and also factoring existing code (to avoid duplication).

They are good candidates for APR-1.6.