Bug 57039 - Inconsistency with the undo/redo log
Summary: Inconsistency with the undo/redo log
Status: NEW
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: Nightly (Please specify date)
Hardware: All All
: P2 major (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
: 57043 (view as bug list)
Depends on:
Blocks: 42248
  Show dependency tree
 
Reported: 2014-09-29 13:13 UTC by shmulikk
Modified: 2019-05-20 13:36 UTC (History)
4 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description shmulikk 2014-09-29 13:13:16 UTC 
I've started to work with the most recent nightly build (r1628112) to get first feeling with the undo/redo feature.

When traversing with the undo/redo buttons and continue to work normally, it seems like it is possible to loose state.

Reproduce:
1. Create new script
2. Add thread group and undo it.
3. Redo the new thread group.
4. Select the thread group, rename it to "Thread Group 1" and click on Test Plan.
5. Select the thread group, rename it to "Thread Group 2" and click on Test Plan.
6. Select the thread group, rename it to "Thread Group 3" and click on Test Plan.
7. Undo three times and you will get "Thread Group 3" instead of "Thread Group".


This ticket is related to https://issues.apache.org/bugzilla/show_bug.cgi?id=42248
Comment 1 Philippe Mouawad 2014-10-02 20:02:59 UTC 
Affects Nightly (before 2.12) of 2th October 2014
Comment 2 Philippe Mouawad 2014-10-02 20:03:58 UTC 
Affects Nightly (before 2.12) of 2th October 2014
Comment 3 Emilian Bold 2017-07-22 11:18:42 UTC 
See fix in https://github.com/apache/jmeter/pull/300
Comment 4 Philippe Mouawad 2017-09-28 19:15:44 UTC 
Author: pmouawad
Date: Thu Sep 28 19:12:44 2017
New Revision: 1810034

URL: http://svn.apache.org/viewvc?rev=1810034&view=rev
Log:
Bug 57039 - Inconsistency with the undo/redo log
This closes #310
Contributed by Emilian Bold
Bugzilla Id: 57039

Added:
    jmeter/trunk/src/core/org/apache/jmeter/gui/GlobalUndoableEdit.java   (with props)
    jmeter/trunk/src/core/org/apache/jmeter/gui/SimpleCompoundEdit.java   (with props)
    jmeter/trunk/src/core/org/apache/jmeter/gui/TreeState.java   (with props)
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/UndoHistory.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/UndoHistoryItem.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionRouter.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/ResetSearchCommand.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/UndoCommand.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java
Comment 5 Philippe Mouawad 2018-10-28 11:06:22 UTC 
*** Bug 57043 has been marked as a duplicate of this bug. ***
Comment 6 Shane 2019-05-20 13:36:05 UTC 
Has there been any progress on this?
Comment 7 The ASF infrastructure team 2022-09-24 20:37:58 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3442