Bug 57143 - [PATCH] Javadocs and throws clause for WorkbookUtil
Summary: [PATCH] Javadocs and throws clause for WorkbookUtil
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: 3.10-FINAL
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-24 23:53 UTC by Javen O'Neal
Modified: 2014-10-27 00:38 UTC (History)
0 users


Attachments
WorkbookUtil.java patch (1.19 KB, text/plain)
2014-10-24 23:53 UTC, Javen O'Neal 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2014-10-24 23:53:52 UTC 
Created attachment 32146 [details]
WorkbookUtil.java patch

1) org.apache.poi.ss.util.WorkbookUtil.validateSheetName and validateSheetState throw java.lang.IllegalArgumentExceptions but don't declare them in the throws clause.

2) validateSheetState is missing JavaDocs
Comment 1 Andreas Beeker 2014-10-27 00:38:47 UTC 
More or less applied with r1634412
I prefer to use javadoc instead of the throws expression to document runtime exceptions.
see http://stackoverflow.com/questions/16757066/javadoc-and-runtimeexception