Bug 57217 - Aggregate graph and Aggregate report improvements (3 configurable percentiles, same data in both, factor out code)
Summary: Aggregate graph and Aggregate report improvements (3 configurable percentiles...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.12
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-15 14:39 UTC by UbikLoadPack support
Modified: 2014-11-29 10:08 UTC (History)
1 user (show)



Attachments
Patch implementing feature (3.69 KB, patch)
2014-11-15 14:39 UTC, UbikLoadPack support
Details | Diff
Patch that implements comment of 2014-11-29 09:35:46 UTC (22.54 KB, patch)
2014-11-29 09:41 UTC, UbikLoadPack support
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description UbikLoadPack support 2014-11-15 14:39:29 UTC
Hello,
Find attached a patch that adds percentile 95 and 99 to Aggregate report.

Regards
Ubik Load Pack Team
Comment 1 UbikLoadPack support 2014-11-15 14:39:58 UTC
Created attachment 32206 [details]
Patch implementing feature
Comment 2 Sebb 2014-11-15 19:08:49 UTC
Thanks for the patch.

But what is the use-case for adding these particular %ages?
Why not 97% or 98% (etc.) as well?

It might be more useful to make the %ages completely flexible.
Comment 3 UbikLoadPack support 2014-11-15 19:42:55 UTC
These percentiles are usually the most commonly used when we do load testing campaigns for our customer. 
Maybe we could default to these and add properties to allow choosing 3 values for the percentile:
- aggregate_rpt_percentile_1 (default to 90)
- aggregate_rpt_percentile_2 (default to 95)
- aggregate_rpt_percentile_3 (default to 99)
Comment 4 UbikLoadPack support 2014-11-29 09:35:46 UTC
Hello,
After your comment on this issue, we reviewed the code of both Aggregate graph and Aggregate report.
We will contribute a patch that:
- Makes Aggregate Graph display the same data as Report in the upper table (this will allow users to only use Aggregate Graph when they want table+graph)
- We added the ability to have 3 configurable percentiles as per your request, which now default to 90%, 95% and 99%. These can be float values and are configurable in user.properties
- We factored out code between the 2 listeners
- We fixed a centering issue of Table headers in Aggregate graph


Regards
Ubik Load Pack Team
@ubikloadpack
Comment 5 UbikLoadPack support 2014-11-29 09:41:22 UTC
Created attachment 32238 [details]
Patch that implements comment of 2014-11-29 09:35:46 UTC
Comment 6 Philippe Mouawad 2014-11-29 10:08:19 UTC
Date: Sat Nov 29 10:06:00 2014
New Revision: 1642410

URL: http://svn.apache.org/r1642410
Log:
Bug 57217 - Aggregate graph and Aggregate report improvements (3 configurable percentiles, same data in both, factor out code)
Bugzilla Id: 57217

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/BarGraph.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/HeaderAsPropertyRenderer.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml


Date: Sat Nov 29 10:07:10 2014
New Revision: 1642412

URL: http://svn.apache.org/r1642412
Log:
Bug 57217 - Aggregate graph and Aggregate report improvements (3 configurable percentiles, same data in both, factor out code)
Add screenshots
Bugzilla Id: 57217

Modified:
    jmeter/trunk/docs/images/screenshots/aggregate_graph.png
    jmeter/trunk/docs/images/screenshots/aggregate_report.png
    jmeter/trunk/docs/images/screenshots/aggregate_report_grouped.png
    jmeter/trunk/xdocs/images/screenshots/aggregate_graph.png
    jmeter/trunk/xdocs/images/screenshots/aggregate_report.png
    jmeter/trunk/xdocs/images/screenshots/aggregate_report_grouped.png
Comment 7 Philippe Mouawad 2014-11-29 10:08:53 UTC
Thanks for contribution. Commited with addition of screenshots and size change of images in component_reference.xml.