Bug 57433 - Double-check locking in ExpressionEvaluatorManager
Summary: Double-check locking in ExpressionEvaluatorManager
Status: RESOLVED FIXED
Alias: None
Product: Taglibs
Classification: Unclassified
Component: Standard Taglib (show other bugs)
Version: 1.2.1
Hardware: All All
: P2 minor (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on: 25967
Blocks:
  Show dependency tree
 
Reported: 2015-01-11 19:26 UTC by Jeremy Boynes
Modified: 2015-01-11 21:39 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Boynes 2015-01-11 19:26:50 UTC 
http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.1/jstlel/src/main/java/org/apache/taglibs/standard/lang/support/ExpressionEvaluatorManager.java?view=markup#l103

The default implementation, org.apache.taglibs.standard.lang.jstl.Evaluator, does not have any instance fields so we may not see issues in the wild. The taglibs code specifies a constant value for the name so it will always use that implementation. However, other implementations stored in the cache may not be safe.
Comment 1 Jeremy Boynes 2015-01-11 21:39:32 UTC 
Fixed in http://svn.apache.org/r1650974

As our code always uses our implementation, use a single instance of that.

Deprecate the public method that provides access to the cache in anticipation
of removal in a future major version.