Bug 57515 - Define/Undefine don't work reasonably outside of global scope
Summary: Define/Undefine don't work reasonably outside of global scope
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.5-HEAD
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 15:39 UTC by Eric Covener
Modified: 2015-01-30 16:26 UTC (History)
0 users



Attachments
block dir context + doc vhost behavior (4.13 KB, patch)
2015-01-30 16:04 UTC, Eric Covener
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Covener 2015-01-30 15:39:54 UTC
Config defines are global, but we allow them to be defined/undefine in vhost and per-directory context.

Because they are exec_on_read, they are doubly broken in directory context.

I think they need to be GLOBAL_ONLY.  http://people.apache.org/~covener/patches/define.diff
Comment 1 Eric Covener 2015-01-30 15:58:49 UTC
I guess there is value in virtualhost, the original PR 35350 has a config where some define is set right before including a common file.
Comment 2 Eric Covener 2015-01-30 16:04:26 UTC
Created attachment 32413 [details]
block dir context + doc vhost behavior
Comment 3 Eric Covener 2015-01-30 16:26:05 UTC
patch doesn't actually work because of something about EXEC_ON_READ