Created attachment 32519 [details] Change the default to something that seems valid It passes "all" which is not valid if you read acinclude.m4. This patch changes it to the undocumented maybe-all which seems to be the closest one to what I imagine "all" would mean.
This seems to have been the rationale: http://svn.apache.org/viewvc?view=revision&revision=1396440
Anything other than "yes|static|shared" will have the wanted effect of setting _apmod_required="no", but "all" is not an expected value. Other expected values are: - "most" which only tries to enable it if "most", "all" or "reallyall" modules are requested - "maybe-all" which only tries to enable it if "all" or "reallyall" modules are requested - "no" which only tries to enable it if "reallyall" modules are requested Everything else is not explicitely handled andjust going through the != "no". This means in particular that it is not set to $module_default (static or shared) but always shared. "maybe-all" is actually what is used if an empty argument is passed, and means "disabled under default, most. enabled explicitly or with all." So this patch causes a change as it will not be enabled if people request "none", "few"or "most" modules while it currently is (which seems wrong for "none" and "few"). Changing it to "most" or "" may be better but current value is wrong.
I changed it to "no" in r1872763 so it's disabled by default for "all", which makes more sense to me since it does change behaviour if loaded.