Bug 58217 - support alpha channel on solid colors (fill, line, text)
Summary: support alpha channel on solid colors (fill, line, text)
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 3.15-dev
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2015-08-06 11:10 UTC by mark.o
Modified: 2016-05-23 00:02 UTC (History)
0 users



Attachments
patch with proposed changes (9.30 KB, patch)
2015-08-06 11:10 UTC, mark.o
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mark.o 2015-08-06 11:10:52 UTC
Created attachment 32976 [details]
patch with proposed changes

Was previously missing.
The implementation takes the alpha channel from the Java Color. This is probably less clutter than adding an additional setAlpha method.

Added use to Tutorial3.

NB: the alpha channel only works for setters, not getters.
Comment 1 Nick Burch 2015-08-06 11:18:39 UTC
Normal HSSF colours don't have an alpha channel. Extended HSSF colours do, as do non-theme XSSF colours

If you haven't already, it might be worth you looking at how it works (or doesn't...) for SpreadSheet extended colours / xssf colours, then see if there are any ideas from there that can be used in the slideshow side / good ideas from the slideshow side which can go to spreadsheet
Comment 2 mark.o 2015-08-06 12:02:35 UTC
(In reply to Nick Burch from comment #1)
> If you haven't already, it might be worth you looking at how it works (or
> doesn't...) for SpreadSheet extended colours / xssf colours, then see if
> there are any ideas from there that can be used in the slideshow side / good
> ideas from the slideshow side which can go to spreadsheet

I did take a look some of the spreadsheet implementation ... quite hairy.
I'd guess the first step would be to at least commonalize some of the hslf/xslf colour handling.
Comment 3 Andreas Beeker 2016-05-23 00:02:24 UTC
Thanks for your patch.
Applied and adapted via r1745101

Instead of the static method setFillColor, I've decided to apply the color 
change via a XSLFColor instance