Bug 58253 - [PATCH] Minor changes to CellReference
Summary: [PATCH] Minor changes to CellReference
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 03:30 UTC by Javen O'Neal
Modified: 2015-08-18 14:46 UTC (History)
0 users



Attachments
CellReference.java patch (3.65 KB, patch)
2015-08-18 03:30 UTC, Javen O'Neal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2015-08-18 03:30:51 UTC
Created attachment 33006 [details]
CellReference.java patch

A few minor changes to CellReference:

* Compare cellRefString.toUpperCase() with "#REF!" for CellReference(String)
* Change private separateRefParts(String) to return a struct instead of a 3-element String array. The goal here was to make the code easier to read and more flexible if POI supports cell references external to the workbook, though I don't know if creating an object is more expensive (time or memory) than a String array. Do we have a good way to test this?
* Update javadoc for separateRefParts
Comment 1 Nick Burch 2015-08-18 14:46:42 UTC
Thanks, patch committed in r1696430.

(Even if the string[] is a smidgen faster, readability is important to, so seems worth it)