Bug 58344 - allow to run tests against Tomcat installed from vendor package
allow to run tests against Tomcat installed from vendor package
Status: RESOLVED FIXED
Product: Tomcat 8
Classification: Unclassified
Component: Meta
8.0.x-trunk
PC Solaris
: P2 normal (vote)
: ----
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2015-09-08 07:59 UTC by Petr Sumbera
Modified: 2015-09-10 14:47 UTC (History)
0 users



Attachments
prototype patch file. (3.23 KB, patch)
2015-09-08 07:59 UTC, Petr Sumbera
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Sumbera 2015-09-08 07:59:23 UTC
Created attachment 33080 [details]
prototype patch file.

It would be nice to allow redirect Tomcat test suite to test Tomcat from different location than tomcat.build directory. This could be used for 'system-test'. E.g. to find out whether some other change didn't break Tomcat.

This is not just to redefine tomcat.build to some different location. Because on Unix systems Tomcat can be packaged in both location /usr and /var. Where /usr location should remain read only.

Therefore I have added test.basedir which points to location where are conf/ (for logging.properties) and webapps/ directories. Plus tomcat.testrunclasses which can be redirected to Tomcat jar files.

See attached patch file for some ideas. Where following arguments are used for Tomcat installed on Solaris:

ant -Dbase.path=/builds/psumbera/userland-tomcat8-tests/components/tomcat-8/build/i386 -Dtomcat.build=/builds/psumbera/userland-tomcat8-tests/components/tomcat-8/build/prototype/i386 -Djunit.home=/usr/share/lib/java -Dtest.reports=/builds/psumbera/userland-tomcat8-tests/components/tomcat-8/build/i386/log -Dtest.temp=/builds/psumbera/userland-tomcat8-tests/components/tomcat-8/build/i386/temp -Dtest.basedir=/var/tomcat8 -Dtomcat.testrunclasses=/usr/tomcat8/lib/*:/usr/tomcat8/bin/* test
Comment 1 Mark Thomas 2015-09-10 14:47:12 UTC
Thanks for the report and the proposed patch.

I have applied the patch to trunk and 8.0.x for 80.27 onwards.