Bug 58441 - [PATCH] Define equals method for CellRangeAddressBase
Summary: [PATCH] Define equals method for CellRangeAddressBase
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks: 58348
  Show dependency tree
 
Reported: 2015-09-21 21:25 UTC by Javen O'Neal
Modified: 2015-10-23 11:18 UTC (History)
0 users



Attachments
CellRangeAddressBase with added equals and hashCode methods (1.34 KB, patch)
2015-09-21 21:25 UTC, Javen O'Neal
Details | Diff
CellRangeAddressBase with added equals and hashCode methods, including unit tests (3.58 KB, patch)
2015-09-21 21:57 UTC, Javen O'Neal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2015-09-21 21:25:41 UTC
Created attachment 33124 [details]
CellRangeAddressBase with added equals and hashCode methods

CellRangeAddressBase doesn't have an equals method.

Equals method should determine if two CellRangeAddressBases refer to the same area by comparing _firstRow, _lastRow, _firstCol, _lastCol. Since it's possible for (_firstRow and _lastRow) and (_firstCol and _lastCol) to become inverted, a comparison should sort the fields.
Comment 1 Javen O'Neal 2015-09-21 21:57:56 UTC
Created attachment 33125 [details]
CellRangeAddressBase with added equals and hashCode methods, including unit tests

Add unit tests for new methods.
Comment 2 Javen O'Neal 2015-10-23 11:18:47 UTC
Implemented in r1710172

Deployed to trunk.