Bug 58546 - SecureNio2Channel inner class GatherState should be static
Summary: SecureNio2Channel inner class GatherState should be static
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Util (show other bugs)
Version: 8.0.x-trunk
Hardware: Macintosh Mac OS X 10.1
: P2 trivial (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-25 22:52 UTC by Anthony Whitford
Modified: 2015-10-26 08:26 UTC (History)
0 users



Attachments
Makes GatherState a static inner class (492 bytes, patch)
2015-10-25 22:52 UTC, Anthony Whitford
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Whitford 2015-10-25 22:52:35 UTC
Created attachment 33218 [details]
Makes GatherState a static inner class

Since GatherState does not need its parent SecureNio2Channel, the class can be made static to be leaner.

See http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC
Comment 1 Violeta Georgieva 2015-10-26 08:26:58 UTC
Hi,

Thanks for the report and the patch.
The fix is available in 8.0.x for 8.0.29 onwards

Regards,
Violeta