Bug 58570 - SXSSFCell.setAsActiveCell silently does nothing
Summary: SXSSFCell.setAsActiveCell silently does nothing
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SXSSF (show other bugs)
Version: 3.14-dev
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-02 02:09 UTC by Javen O'Neal
Modified: 2015-12-04 06:58 UTC (History)
0 users



Attachments
SXSSFCell.setAsActiveCell should throw an exception until it's fully implemented (779 bytes, patch)
2015-11-02 02:09 UTC, Javen O'Neal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2015-11-02 02:09:13 UTC
Created attachment 33245 [details]
SXSSFCell.setAsActiveCell should throw an exception until it's fully implemented

Right now SXSSFCell silently does nothing. It should either log that it's a non-operation or throw some exception that the setAsActiveCell is not relevant or not supported for SXSSFWorkbooks, until someone can determine a better solution.
Comment 1 Javen O'Neal 2015-11-30 09:22:49 UTC
Added NotImplemented decorator and made method throw RuntimeException(NotImplemented) in r1717164 [1].

This didn't break the Jenkins build, which also means this isn't unit tested.

http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java?annotate=1717164&diff_format=h#l569
Comment 2 Javen O'Neal 2015-12-04 06:58:39 UTC
In r1717900:
Add CellAddress Sheet.getActiveCell() (previously only available in XSSFSheet, backwards-compatibility note: previously returned a String)
Add void Sheet.setActiveCell(CellAddress)
Add Cell.getAddress() to support this (CellAddress(Cell) could also be used)
Add unit tests for Cell.setAsActiveCell()
Add unit tests for Sheet.getActiveCell and Sheet.setActiveCell

In summary, SXSSFCell.setAsActiveCell is now implemented!

Future public methods that are not implemented should be annotated with @NotImplemented per comment 1.

Updated docs in r1717901